fix: ensure scrollbar reaches screen edge on large screens by applying maxWidth constraints locally#189
Merged
payam-zahedi merged 1 commit intopayam-zahedi:mainfrom Feb 26, 2025
Conversation
…g maxWidth constraints locally - Moved maxWidth constraint from ResponsiveWrapper.builder to a constant (kMaxWidth) in responsive.dart. - Applied maxWidth constraint only to the main content instead of globally, allowing the scrollbar to take full width. - Fixed scrollbar visibility issue on large screens while maintaining content width constraints.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 74.30% 74.30%
=======================================
Files 31 31
Lines 895 895
=======================================
Hits 665 665
Misses 230 230
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
payam-zahedi
approved these changes
Feb 26, 2025
Owner
payam-zahedi
left a comment
payam-zahedi
left a comment
There was a problem hiding this comment.
Thank you, @reza00farjam!
Great job—Can't wait for your next Contribution 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: