Skip to content

feat: add customizable constraints for each toast in show method#220

Merged
payam-zahedi merged 3 commits intopayam-zahedi:mainfrom
jahnli:feat-change-minHeight
Jun 7, 2025
Merged

feat: add customizable constraints for each toast in show method#220
payam-zahedi merged 3 commits intopayam-zahedi:mainfrom
jahnli:feat-change-minHeight

Conversation

@jahnli
Copy link
Contributor

@jahnli jahnli commented Jun 6, 2025

The toast height is allowed to be adjusted

@jahnli
Copy link
Contributor Author

jahnli commented Jun 6, 2025

Would it be better to cancel minheight ? By default, the height of the element is the standard, and the final height of the element is determined by setting the padding @payam-zahedi

Copy link
Owner

@payam-zahedi payam-zahedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jahnli

I added some changes on your code
I think it makes more sense to give the users access to the constraints instead of only minHeight.

@codecov
Copy link

codecov bot commented Jun 7, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.34%. Comparing base (fa48d20) to head (16f0b23).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/built_in/layout/standard/style/style.dart 83.33% 1 Missing ⚠️
...standard/toast/minimal/minimal_standard_toast.dart 0.00% 1 Missing ⚠️
...t/standard/toast/simple/simple_standard_toast.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
- Coverage   74.36%   74.34%   -0.02%     
==========================================
  Files          31       31              
  Lines         905      916      +11     
==========================================
+ Hits          673      681       +8     
- Misses        232      235       +3     
Flag Coverage Δ
flutter 74.34% <72.72%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@payam-zahedi payam-zahedi changed the title feat: add min height params for show feat: add customizable constraints for each toast in show method Jun 7, 2025
@payam-zahedi payam-zahedi merged commit 3926fee into payam-zahedi:main Jun 7, 2025
2 of 4 checks passed
@jahnli
Copy link
Contributor Author

jahnli commented Jun 7, 2025

Yes, that would be better. Please help me approve #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants