feat: add customizable constraints for each toast in show method#220
feat: add customizable constraints for each toast in show method#220payam-zahedi merged 3 commits intopayam-zahedi:mainfrom
Conversation
|
Would it be better to cancel minheight ? By default, the height of the element is the standard, and the final height of the element is determined by setting the padding @payam-zahedi |
…into pr/jahnli/220
payam-zahedi
left a comment
There was a problem hiding this comment.
Hey @jahnli
I added some changes on your code
I think it makes more sense to give the users access to the constraints instead of only minHeight.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
- Coverage 74.36% 74.34% -0.02%
==========================================
Files 31 31
Lines 905 916 +11
==========================================
+ Hits 673 681 +8
- Misses 232 235 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Yes, that would be better. Please help me approve #218 |
The toast height is allowed to be adjusted