feat: pass args to task onSuccess
and onFail
callbacks
#13269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Passes the same args provided to a task's
shouldRestore
function to both theonSuccess
&onFail
callbacksWhy?
Currently
onSuccess
andonFail
are quite useless without any context, this will allow for a wider range of functionality:input
req
to allow logging, email notifications, etc.How?
TaskCallbackArgs
type, which replicates the args of theShouldRestoreFn
type.TaskCallbackFn
typeonSuccess
andonFail
.Questions
input
– I can seeinput: input!
being used elsewhere for task errors so I replicated that.taskStatus
, I added a type check but I'm not sure if this is the right approach (what would scenario would result in anull
value?). ShouldTaskCallbackArgs['taskStatus']
be typed to allow fornull
values?