Skip to content

Conversation

DanRibbens
Copy link
Contributor

@DanRibbens DanRibbens commented Aug 5, 2025

What:

This PR adds limit and page fields to the export options, allowing users to control the number of documents exported and the page from which to start the export. It also enforces that limit must be a positive multiple of 100.

Why:

This feature is needed to provide pagination support for large exports, enabling users to export manageable chunks of data rather than the entire dataset at once. Enforcing multiples-of-100 for limit ensures consistent chunking behavior and prevents unexpected export issues.

How:

  • The limit field determines the maximum number of documents to export and must be a positive multiple of 100.
  • The page field defines the starting page of the export and is displayed only when a limit is specified.
  • If limit is cleared, the page resets to 1 to maintain consistency.
  • Export logic was adjusted to respect the limit and page values when fetching documents.

@DanRibbens DanRibbens force-pushed the feat/plugin-import-export-page branch from ac3cbe6 to c245181 Compare August 5, 2025 19:33
@PatrikKozak PatrikKozak changed the title feat(plugin-import-export): export pagination feat(plugin-import-export): adds limit and page fields to export options Aug 11, 2025
@PatrikKozak PatrikKozak marked this pull request as ready for review August 11, 2025 21:09
@PatrikKozak PatrikKozak requested a review from denolfe as a code owner August 11, 2025 21:09
Copy link
Contributor

github-actions bot commented Aug 11, 2025

📦 esbuild Bundle Analysis for payload

This analysis was generated by esbuild-bundle-analyzer. 🤖
This PR introduced no changes to the esbuild bundle! 🙌

Copy link
Contributor Author

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need test coverage.

@DanRibbens
Copy link
Contributor Author

Looks good. I can't approve because I opened the PR initially. @PatrikKozak you can approve and merge if you're good with the changes as they are.

@PatrikKozak PatrikKozak merged commit c1c68fb into main Aug 13, 2025
164 of 166 checks passed
@PatrikKozak PatrikKozak deleted the feat/plugin-import-export-page branch August 13, 2025 21:01
jacobsfletch added a commit that referenced this pull request Aug 14, 2025
CI is blocked because of failing int tests within the import/export
plugin suite after #13380.
Copy link
Contributor

🚀 This is included in version v3.52.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants