-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(plugin-import-export): adds limit and page fields to export options #13380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ac3cbe6
to
c245181
Compare
…-import-export-page
…-import-export-page
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need test coverage.
…-import-export-page
…-import-export-page
Looks good. I can't approve because I opened the PR initially. @PatrikKozak you can approve and merge if you're good with the changes as they are. |
CI is blocked because of failing int tests within the import/export plugin suite after #13380.
🚀 This is included in version v3.52.0 |
What:
This PR adds
limit
andpage
fields to the export options, allowing users to control the number of documents exported and the page from which to start the export. It also enforces that limit must be a positive multiple of 100.Why:
This feature is needed to provide pagination support for large exports, enabling users to export manageable chunks of data rather than the entire dataset at once. Enforcing multiples-of-100 for
limit
ensures consistent chunking behavior and prevents unexpected export issues.How:
limit
field determines the maximum number of documents to export and must be a positive multiple of 100.page
field defines the starting page of the export and is displayed only when alimit
is specified.limit
is cleared, thepage
resets to 1 to maintain consistency.limit
andpage
values when fetching documents.