-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(ui): bulk upload issues #13413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): bulk upload issues #13413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what we do everywhere else, but this actually will evaluate to undefined/api/route
if you don't define a serverURL. Can you see what we do elsewhere?
It's already depended on elsewhere in the same file e.g.
Besides, it should never be
|
The test failure is down to Docker Hub rate limiting, don't think there's anything I can really do about it |
I've found another of these invalid fetch calls (that don't work with a custom API URL) in |
Another PR would be great. |
What?
This PR contains a couple of fixes to the bulk upload process:
Why?
I use separate admin and API URLs and work off a remote dev server using custom hostnames. These issues may not impact the happy path of using localhost, but are dealbreakers in this environment.
Fixes
These are issues I found myself, I fixed them rather than raising issues for somebody else to pick up, but I can create issues to link to if required.