fix(ui): autosave hooks are not reflected in form state #13416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobsfletch
changed the title
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
paulpopus
approved these changes
Aug 11, 2025
DanRibbens
approved these changes
Aug 11, 2025
jacobsfletch
added a commit
that referenced
this pull request
Aug 12, 2025
Follow-up to #13416. Supersedes #13434. When autosave is triggered and the user continues to modify fields, their changes are overridden by the server's value, i.e. the value at the time the form state request was made. This makes it almost impossible to edit fields when using a small autosave interval and/or a slow network. This is because autosave is now merged into form state, which by default uses `acceptValues: true`. This does exactly what it sounds like, accepts all the values from the server—which may be stale if underlying changes have been made. We ignore these values for onChange events, because the user is actively making changes. But during form submissions, we can accept them because the form is disabled while processing anyway. This pattern allows us to render "computed values" from the server, i.e. a field with an `beforeChange` hook that modifies its value. Autosave, on the other hand, happens in the background _while the form is still active_. This means changes may have been made since sending the request. We still need to accept computed values from the server, but we need to avoid doing this if the user has active changes since the time of the request. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1211027929253429
|
🚀 This is included in version v3.51.0 |
This was referenced Aug 14, 2025
jacobsfletch
added a commit
that referenced
this pull request
Aug 20, 2025
No need to re-fetch doc permissions during autosave. This will save us from making two additional client-side requests on every autosave interval, on top of the two existing requests needed to autosave and refresh form state. This _does_ mean that the UI will not fully reflect permissions again until you fully save, or until you navigating back, but that has always been the behavior anyway (until #13416). Maybe we can find another solution for this in the future, or otherwise consider this to be expected behavior. --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1211094073049052
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10515. Needed for #12956.
Hooks run within autosave are not reflected in form state.
Similar to #10268, but for autosave events.
For example, if you are using a computed value, like this:
In the example above, when an autosave event is triggered after changing the
titlefield, we expect thecomputedTitlefield to match. But although this takes place on the database level, the UI does not reflect this change unless you refresh the page or navigate back and forth.Here's an example:
Before:
before.mp4
After:
after.mp4