chore(ui): robust a11y for the tree view table #14397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmance when querying multiple times on postgres (#14315) 1. Fixes handling of `$exists` when querying a field nested to a join field. 2. Avoids adding new SQL joins when querying a join field multiple times before ```sql SELECT DISTINCT "categories"."id", "categories"."created_at", "categories"."created_at" FROM "categories" LEFT JOIN "posts_rels" AS "c40660ed_b4bf_4644_bbd1_b7225045bb92" ON ( "categories"."id" = "c40660ed_b4bf_4644_bbd1_b7225045bb92"."categories_id" AND "c40660ed_b4bf_4644_bbd1_b7225045bb92"."path" LIKE ? ) LEFT JOIN "posts" AS "6702692c_e77e_41b3_ab0c_038d8ca584f6" ON "c40660ed_b4bf_4644_bbd1_b7225045bb92"."parent_id" = "6702692c_e77e_41b3_ab0c_038d8ca584f6"."id" LEFT JOIN "posts" AS "b8d97c7b_51c7_448e_96dd_567ac0a24ccf" ON "c40660ed_b4bf_4644_bbd1_b7225045bb92"."parent_id" = "b8d97c7b_51c7_448e_96dd_567ac0a24ccf"."id" LEFT JOIN "posts" AS "89586995_3641_4226_b047_dc3c96b33d9f" ON "c40660ed_b4bf_4644_bbd1_b7225045bb92"."parent_id" = "89586995_3641_4226_b047_dc3c96b33d9f"."id" WHERE "6702692c_e77e_41b3_ab0c_038d8ca584f6"."title" = ? AND "b8d97c7b_51c7_448e_96dd_567ac0a24ccf"."title" IS NOT NULL AND "89586995_3641_4226_b047_dc3c96b33d9f"."is_filtered" = ? ORDER BY "categories"."created_at" DESC LIMIT ? -- params: ["categories", "my-title", 1, 10] ``` now ```sql SELECT DISTINCT "categories"."id", "categories"."created_at", "categories"."created_at" FROM "categories" LEFT JOIN "posts_rels" AS "b6ba04a3_a557_4321_abfb_7b58250baa2c" ON ( "categories"."id" = "b6ba04a3_a557_4321_abfb_7b58250baa2c"."categories_id" AND "b6ba04a3_a557_4321_abfb_7b58250baa2c"."path" LIKE ? ) LEFT JOIN "posts" AS "86c9090f_c50b_485d_a9bb_1ca8b5ad079d" ON "b6ba04a3_a557_4321_abfb_7b58250baa2c"."parent_id" = "86c9090f_c50b_485d_a9bb_1ca8b5ad079d"."id" WHERE "86c9090f_c50b_485d_a9bb_1ca8b5ad079d"."title" = ? AND "86c9090f_c50b_485d_a9bb_1ca8b5ad079d"."title" IS NOT NULL AND "86c9090f_c50b_485d_a9bb_1ca8b5ad079d"."is_filtered" = ? ORDER BY "categories"."created_at" DESC LIMIT ? -- params: ["categories", "my-title", 1, 10] ```
Fixes #13947 This change will present the leave without saving modal when a user has edits on a document in a drawer and then attempts to close the drawer.
Adds example to Groups to show they can have name or label
I reviewed the docs for spelling, grammar, and major punctuation issues. This PR only fixes English-language errors and doesn’t modify code examples.
Fixes #14299 Using `filterAvailableLocales` means they could change when the req changes. When we get the client config from the cache, we need to re-apply `filterAvailableLocales` so the config has the correct values. This was manually being done in the Root layout, but every other place that called getClientConfig was not i.e. the Root view. So this PR moves that logic from the Root layout into the getClientConfig function.
JarrodMFlesch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.