Conversation
🦋 Changeset detectedLatest commit: 17e89f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nityasp
left a comment
nityasp
left a comment
There was a problem hiding this comment.
LGTM!! Good job @HackTheW2d
| /** | ||
| * Cancels the current session | ||
| * | ||
| * @remarks | ||
| * Cleans up session resources and listeners. | ||
| */ | ||
| cancel(): void; | ||
|
|
||
| /** | ||
| * Destroys the session | ||
| * | ||
| * @remarks | ||
| * Performs complete cleanup and makes the session unusable. | ||
| */ | ||
| destroy(): void; |
There was a problem hiding this comment.
Would you mind double checking whether these methods are included on the Session class?
There was a problem hiding this comment.
Yeah. Good callout! I was thinking if it's helpful when merchants cancel the payment. But looks like it should be handled by google side. I'll remove this
| /** | ||
| * @module | ||
| * @internal | ||
| */ |
There was a problem hiding this comment.
I think we should remove this @internal tag since there are types being exported publically from the file.
| * These are the parameters passed to session.confirmOrder(). | ||
| * The clientId is managed internally by the SDK. | ||
| */ | ||
| type GooglePayConfirmOrderOptions = { |
There was a problem hiding this comment.
What do you think about exporting this? It would be helpful for a dev typing the options object, in case it is created dynamically or something.
4 participants
Add google payments types to v6 vanilla JS types