refactor: adds v6 modal tracking key integration_identifier#1196
Merged
refactor: adds v6 modal tracking key integration_identifier#1196
Conversation
danzhaaspaypal
changed the title
danzhaaspaypal
changed the title
merlinpaypal
approved these changes
May 9, 2025
Contributor
merlinpaypal
left a comment
merlinpaypal
left a comment
There was a problem hiding this comment.
Not blockers but src/components/modal/v2/lib/postMessage.js and src/components/modal/v2/parts/InlineLinks.jsx have lint warnings. Since those seem intentional, perhaps we could add // eslint-disable-next-line no-console and // eslint-disable-next-line react/no-danger to those lines so we don't get the warnings.
The actual PR content looks good to me
Seavenly
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2025
### [1.68.3](v1.68.2...v1.68.3) (2025-05-13) ### Code Refactoring * adds v6 modal tracking key integration_identifier ([#1196](#1196)) ([63d9691](63d9691))
|
🎉 This PR is included in version 1.68.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
integration_identifierfor tracking when a modal is integrated via the standalone vs message-linked integration.integration_identifier: describes if the modal was integrated as standalone or rather with a message. Sample value:messagesModalDescription
Allows tracking of
integration_identifier.Takes
integration_identifierquery params that originated in v6 wrapper and passes it to glog asINTEGRATION_ID.Screenshots
Standalone modal sample output (has
INTEGRATION_ID)Testing instructions
When looking at v6 demo page, check the glog output of modal events
onShow,onCalculate, andonClose. For the standalone modal only, component keyINTEGRATION_IDshould have valuemessagesModal; the key will be absent for a normal message's modal.