Update Customer class to allow nullable networkAddress and countryCod…#103
Merged
kotivuori merged 1 commit intopaytrail:masterfrom Dec 10, 2025
Merged
Update Customer class to allow nullable networkAddress and countryCod…#103kotivuori merged 1 commit intopaytrail:masterfrom
kotivuori merged 1 commit intopaytrail:masterfrom
Conversation
bartoszkaluzny-solteq
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update enhances the customer data handling logic by ensuring that the setNetworkAddress() and setCountryCode() methods are only executed when their respective properties are explicitly provided.
Changes Made:
Added conditional checks for $customer->network_address and $customer->country_code.
The setters are now called only if the properties exist and are not null.
Prevents unintentional overwriting of existing values with null.
Technical Summary:
Testing Notes:
Verified with and without network_address and country_code fields.
Confirmed that the setters trigger correctly only when valid values are passed.