Skip to content

Commit 8b9715c

Browse files
committed
PipeCommand: pass shell arg to ExternalCommand.
Prior to this branch, `shell=True` was passed to Popen regardless of whether `--shell` was passed. I'm not sure why this was the case but it wasn't a problem. Now that we're passing to ExternalCommand, this doesn't work because ExternalCommand does it's own manipulation of cmd when shell=False which is incompatible with a list-style cmd.
1 parent d1a0480 commit 8b9715c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

alot/commands/thread.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ def callback(out):
801801

802802
await ui.apply_command(ExternalCommand(cmd,
803803
stdin=mail,
804-
shell=True,
804+
shell=self.shell,
805805
thread=self.background,
806806
on_success=callback))
807807

0 commit comments

Comments
 (0)