Take 3: Mimetree and mime part support. Resolve #862.#1480
Merged
pazz merged 13 commits intopazz:masterfrom May 6, 2020
Merged
Take 3: Mimetree and mime part support. Resolve #862.#1480pazz merged 13 commits intopazz:masterfrom
pazz merged 13 commits intopazz:masterfrom
Conversation
The command is implemented analogous to togglesource and similar commands. But this commit only contains the toggleing logic and no generation of actual mime trees.
Only minimal information and no indenting is shown until now.
It is suggested in pazz#862: > something like select to display a rendered version of the current mime part > (either inside the tree or in a new buffer) I played around with these options before arriving at the current behavior. Adding the mime part content to the mimetree seemed made for a very busy/over-nested screen and didn't seem all that useful. Likewise opening in another buffer doesn't seem useful and might need a new Buffer subclass in order to be well labeled. The `select` behavior I ended up going with was to change the mime part chosen by default in the Message itself. This should make implementing other commands (e.g. pipeto) on the mime parts trivial. I took `select` a step further by also having it conveniently togglemimetree off. I can't think of any use case for remaining in the mimetree view after making a selection.
This allows attachments to be opened from the mime tree the same way they would be opened in the message tree.
This was referenced Mar 23, 2020
pazz
approved these changes
Mar 27, 2020
Owner
pazz
left a comment
pazz
left a comment
There was a problem hiding this comment.
looks good to me at first glance.
Thanks for adding bindings and statusline support.
Owner
|
@lucc what do you think? |
This was referenced Jun 1, 2020
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes #1475 in response to the review there.