commands/thread/open-attachment: add command#1505
commands/thread/open-attachment: add command#1505pacien wants to merge 2 commits intopazz:masterfrom
Conversation
Completing the already existing on_success for callbacks that should be executed even after a non-zero exit code.
pacien
force-pushed
the
command-open-attachment
branch
7 times, most recently
from
1979cd9 to
9a75424
Compare
|
I'd rather not call this command |
pacien
force-pushed
the
command-open-attachment
branch
from
9a75424 to
7af6934
Compare
|
Amended to rename the command to "open-attachment". |
pacien
changed the title
pacien
changed the title
pacien
force-pushed
the
command-open-attachment
branch
from
7af6934 to
13186af
Compare
| raise RuntimeError('not focused on an attachment') | ||
|
|
||
| @staticmethod | ||
| def _make_temp_file(attachment, prefix='', suffix=''): |
There was a problem hiding this comment.
This seems overcomplicated to me. Why not just extend tempfile.NamedTemporaryFile and return a contextmanager?
There was a problem hiding this comment.
The ExternalCommand in charge of executing the command using the temporary file does not accept context managers. It's not either possible to use a "with" block on top of it because it can spawn an independent thread.
|
I feel like I have implemented a very similat logic in |
This allows the user to open an attachment file with a program of their choice. GitHub: closes pazz#1494
pacien
force-pushed
the
command-open-attachment
branch
from
13186af to
ebbb23c
Compare
|
The EditCommand and OpenAttachmentCommand implementations do not seem to share much in common: the way the file path is substituted in the command differs with mailcap templates. |
3 participants
This allows the user to open an attachment file with a program of their choice.
GitHub: closes #1494