commands/search/tag: Narrow search down to needed messages#1688
Open
guludo wants to merge 1 commit intopazz:masterfrom
Open
commands/search/tag: Narrow search down to needed messages#1688guludo wants to merge 1 commit intopazz:masterfrom
guludo wants to merge 1 commit intopazz:masterfrom
Conversation
For some reason, tagging long threads is taking a lot of time in my system. It might be related to the python library for notmuch, since doing the same directly from notmuch CLI is usually fast. In some use cases (e.g. archiving), most of the messages in the thread might already contain the tags being added or removed. We can optimize for this case by narrowing down the search to only the messages that need the update. So, while the slow tagging operation should be properly investigated at the library level, we can proactively optimize the testquery, which is beneficial anyway.
Comment on lines
+219
to
+220
| logging.warning('unandled action %s', self.action) | ||
|
|
There was a problem hiding this comment.
Typo detected in the log message: 'unandled' should be 'unhandled'.
Suggested change
| logging.warning('unandled action %s', self.action) | |
| logging.warning('unhandled action %s', self.action) |
Comment on lines
+219
to
+220
| logging.warning('unandled action %s', self.action) | ||
|
|
There was a problem hiding this comment.
Typo in the warning message: consider changing 'unandled' to 'unhandled'.
Suggested change
| logging.warning('unandled action %s', self.action) | |
| logging.warning('unhandled action %s', self.action) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, tagging long threads is taking a lot of time in my system. It might be related to the python library for notmuch, since doing the same directly from notmuch CLI is usually fast.
In some use cases (e.g. archiving), most of the messages in the thread might already contain the tags being added or removed. We can optimize for this case by narrowing down the search to only the messages that need the update.
So, while the slow tagging operation should be properly investigated at the library level, we can proactively optimize the testquery, which is beneficial anyway.