Add XML conversion to bodies #214
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new XML validation functions just convert the data to JSON before validating the schema. With that we can just convert the data on Request and Response validations just by looking at the content type.
The XML conversion have some peculiarities, like a password field of "123456" being converted into an integer and failing validation, and the boolean conversions failing because of string fields. Because of that, I let the option to enable XML conversion default to
false. If the user does not explicit enables the XML Validation, the validation is ignored just like today.Using the option to validate XML bodies inside the Request/Response validation, we can benefit the schema compilation code.
No breaking changes with the new code