Skip to content

Conversation

@daveshanley
Copy link
Member

@daveshanley daveshanley commented Jan 7, 2026

Numbers in names is more common than I want it to be. the second hit means I need to do something about it.

Also addresses issue #501

Numbers in names is more common than I want it to be. the second hit means I need to do something about it.
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 73.40426% with 50 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.39%. Comparing base (b7fe7bb) to head (d308951).

Files with missing lines Patch % Lines
datamodel/high/v3/path_item.go 50.00% 7 Missing and 3 partials ⚠️
datamodel/high/v3/parameter.go 60.00% 6 Missing and 2 partials ⚠️
datamodel/high/v3/header.go 70.00% 3 Missing and 3 partials ⚠️
datamodel/high/v3/response.go 70.00% 3 Missing and 3 partials ⚠️
datamodel/high/v3/security_scheme.go 53.84% 4 Missing and 2 partials ⚠️
datamodel/high/base/example.go 69.23% 2 Missing and 2 partials ⚠️
datamodel/high/v3/callback.go 66.66% 2 Missing and 2 partials ⚠️
datamodel/high/v3/request_body.go 73.33% 3 Missing and 1 partial ⚠️
datamodel/high/v3/link.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
- Coverage   99.60%   99.39%   -0.22%     
==========================================
  Files         189      189              
  Lines       22671    22824     +153     
==========================================
+ Hits        22582    22685     +103     
- Misses         56       87      +31     
- Partials       33       52      +19     
Flag Coverage Δ
unittests 99.39% <73.40%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Adds RenderExternalRef() helper functions in shared.go that:

- Check if a low-level object is an external reference
- Resolve it via `FindComponent()`
- Build new low/high level objects from the resolved YAML
- Render the resolved content instead of the empty values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants