Skip to content

Commit afd757e

Browse files
philmdpm215
authored andcommitted
tests/qtest/boot-serial-test: Reduce for() loop in PL011 tests
Since registers are not modified, we don't need to refill their values. Directly jump to the previous store instruction to keep filling the TXDAT register. The equivalent C code remains: while (true) { *UART_DATA = 'T'; } Signed-off-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Reviewed-by: Fabiano Rosas <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
1 parent 16e8c94 commit afd757e

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

tests/qtest/boot-serial-test.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,18 +70,18 @@ static const uint8_t kernel_plml605[] = {
7070
};
7171

7272
static const uint8_t bios_raspi2[] = {
73-
0x08, 0x30, 0x9f, 0xe5, /* loop: ldr r3, [pc, #8] Get &UART0 */
73+
0x08, 0x30, 0x9f, 0xe5, /* ldr r3, [pc, #8] Get &UART0 */
7474
0x54, 0x20, 0xa0, 0xe3, /* mov r2, #'T' */
75-
0x00, 0x20, 0xc3, 0xe5, /* strb r2, [r3] *TXDAT = 'T' */
76-
0xfb, 0xff, 0xff, 0xea, /* b -12 (loop) */
75+
0x00, 0x20, 0xc3, 0xe5, /* loop: strb r2, [r3] *TXDAT = 'T' */
76+
0xff, 0xff, 0xff, 0xea, /* b -4 (loop) */
7777
0x00, 0x10, 0x20, 0x3f, /* UART0: 0x3f201000 */
7878
};
7979

8080
static const uint8_t kernel_aarch64[] = {
81-
0x81, 0x0a, 0x80, 0x52, /* loop: mov w1, #'T' */
81+
0x81, 0x0a, 0x80, 0x52, /* mov w1, #'T' */
8282
0x02, 0x20, 0xa1, 0xd2, /* mov x2, #0x9000000 Load UART0 */
83-
0x41, 0x00, 0x00, 0x39, /* strb w1, [x2] *TXDAT = 'T' */
84-
0xfd, 0xff, 0xff, 0x17, /* b -12 (loop) */
83+
0x41, 0x00, 0x00, 0x39, /* loop: strb w1, [x2] *TXDAT = 'T' */
84+
0xff, 0xff, 0xff, 0x17, /* b -4 (loop) */
8585
};
8686

8787
static const uint8_t kernel_nrf51[] = {

0 commit comments

Comments
 (0)