Allow the user to pass formData via the options.context parameter to authenticate #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate, similar to remix-auth-form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋
Thanks for your work on
remix-auth-email-link. It's a really useful library!Would you consider accepting a PR like this to allow the user to pass
formDatatoauthenticatethe same wayremix-auth-formdoes, as described here?https://remix.run/resources/remix-auth-form-strategy#passing-a-pre-read-formdata-object
This will help me embed a call to authenticate inside an action that can respond to submissions from a couple of different forms.
I see you're doing some interesting stuff to recreate form data from the request, presumably to convert GET requests to POST for when the user click's the magic link. I don't think this PR will mess with that (it works for me) but please let me know if you foresee any problems!