Support JupyterLab 2.0 #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Author
|
There appear to be some issues with things like loading feedback. Unclear to me whether they're related to things in this PR yet. Could use another set of eyes until I'm more familiar with the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to need another pair of eyes, but I wanted to try out the extension and also learn a little more about jupyterlab development. I never used this when it worked with JupyterLab 1.x, so I'm not quite sure what to expect.
The main changes that are needed to update to 2.x are here. The other changes were to the DataGrid API itself, which AFAICT, changed before the move from phosphor to lumino. I'm more confident than nothing in these changes, glancing over the lumino code and given the test suite passing.
For reference, this is the code for the last supported version of datagrid.