Open
Conversation
Member
|
Hi, @PrakharG8651 great to see your enthusiasm, it's correct, but its better to first discuss the issue, as we have mentioned in the guidelines. We will soon look into your PR and merge it. |
Author
|
Thank you, its great discussing these issues as it helps us understand the basics of how github is used |
Member
|
just make a small comment on the issue #58 so that we can assign you that issue 😅 |
Member
|
Why did you force pushed? |
Author
|
Actually I say I used == in place of === ( so I pushed the new code with ===),but when I checked it and got that for numbers it will work fine so to get back original I forced push to initial first commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #58
I just added the simple or condition
currentDate.getDay() == 0
to skip Sundays too.