Skip to content

added feature to notify in case there are no upcoming classes#63

Open
MushMan19 wants to merge 1 commit intopclubiitk:masterfrom
MushMan19:no-upcoming-class-notif
Open

added feature to notify in case there are no upcoming classes#63
MushMan19 wants to merge 1 commit intopclubiitk:masterfrom
MushMan19:no-upcoming-class-notif

Conversation

@MushMan19
Copy link

No description provided.

@this-is-mjk
Copy link
Member

Hi @MushMan19 the code looks mostly correct, we will be testing and merging the PR,
Few suggestions:

  1. It's always good practice to properly description which files you have changes, how you have tested in the PR description.
  2. You should bound your code changes to just what it is going to solve, like in your PR you have added the code which will be working for all the 3 issues we have discussed. It's good, but in general not preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants