Skip to content

Conversation

@OlegMuron
Copy link
Contributor

@OlegMuron OlegMuron commented Jan 18, 2026

The base Illuminate\Queue\Queue class introduced a protected $config property in v12.34.0.
This change matches the visibility to fix the access level error.

See https://github.com/laravel/framework/blame/12.x/src/Illuminate/Queue/Queue.php#L46

Summary by CodeRabbit

  • Refactor
    • Adjusted internal code structure for improved extensibility. No user-facing changes or impact on functionality.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 18, 2026

Walkthrough

A property visibility modifier in the QlessQueue class is changed from private to protected, allowing subclasses to directly access the $config property instead of requiring inheritance-level visibility restrictions.

Changes

Cohort / File(s) Summary
Property Visibility Change
src/Queue/QlessQueue.php
Changed $config property visibility from private to protected, enabling subclass access

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating $config visibility to protected for Laravel v12.34+ compatibility, which matches the core modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-qless-queue-config

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@YaroslavStryhun YaroslavStryhun merged commit 7d4ef53 into master Jan 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants