Improve logic for detecting msys2-based Python (works for 3.11 and 3.…#6
Merged
frostming merged 3 commits intopdm-project:mainfrom Mar 10, 2025
Merged
Improve logic for detecting msys2-based Python (works for 3.11 and 3.…#6frostming merged 3 commits intopdm-project:mainfrom
frostming merged 3 commits intopdm-project:mainfrom
Conversation
Contributor
Author
|
I just ran into this issue again after upgrading |
frostming
reviewed
Mar 5, 2025
Contributor
frostming
left a comment
There was a problem hiding this comment.
Sorry for the late review, I've missed it.
Contributor
Author
|
Thank you for being patient. I have implemented the requested changes. |
frostming
reviewed
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…12).
The MSYS2 project standardized sysconfig names for 3.12, resulting in errors such as the following after an upgrade:
This PR slightly changes the logic introduced by pdm-project/pdm#3158 for detecting the arch in the MSYS2 case (works for 3.12 and while I don't have 3.11 to test right now, I checked that the
mingw_x86_64string also triggers my updated logic.