Skip to content

fix link hijacking issue #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Potherca merged 1 commit into from
Jun 27, 2025
Merged

fix link hijacking issue #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions solid/js/vendor/simplyedit/simply.everything.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,38 +556,6 @@ properties for a given parent, keep seperate index for this?
}
}

var linkHandler = function(evt) {
if (evt.ctrlKey) {
return;
}
if (evt.which != 1) {
return; // not a 'left' mouse click
}
var link = evt.target;
while (link && link.tagName!='A') {
link = link.parentElement;
}
if (link
&& link.pathname
&& link.hostname==global.location.hostname
&& !link.link
&& !link.dataset.simplyCommand
) {
let path = getPath(link.pathname+link.hash);
if ( !route.has(path) ) {
path = getPath(link.pathname);
}
if ( route.has(path) ) {
let params = runListeners('goto', { path: path});
if (params.path) {
route.goto(params.path);
}
evt.preventDefault();
return false;
}
}
};

var options = {
root: '/'
};
Expand Down Expand Up @@ -642,7 +610,6 @@ properties for a given parent, keep seperate index for this?
route.match(getPath(document.location.pathname));
}
});
global.document.addEventListener('click', linkHandler);
},
load: function(routes) {
parseRoutes(routes);
Expand Down