Fix python version detection in filename #40
Merged
+97
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The python version detection logic previously searched for "python" in the full path. This failed for paths where a directory name contained "python" (e.g., .../python39/.../libpython3.9.so), causing the parser to misinterpret the version numbers. Changes: - Parsing logic now searches for "python" only in the filename (after the last slash). - Extracted parsing logic into getPythonVersionFromFilename for better testability. - Improved exception messages to aid debugging. - Added tests/python_path_test.cc to verify correct behavior against various path patterns.
Fix CMake error so that python_path_test.cc test will be compiled and run with -DPYTHON3=on. We need to conditionally compile `python_path_test.cc`. Also, we should not call `add_subdirectory(tests)` at the beginning because otherwise Python3_Development_FOUND will be false when the build process enters `tests/CMakeLists.txt`.
peadar
approved these changes
Jan 15, 2026
| << filename << " (too short)"; | ||
|
|
||
| char majorChar = filename[index + 6]; | ||
| char minorChar = filename[index + 8]; |
Owner
There was a problem hiding this comment.
This particular act of laziness on my part (I think) is gonna bite us with py3.14, but that's not your fault or problem to solve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python version detection logic previously searched for "python" in the full path. This failed for paths where a directory name contained "python" (e.g., .../python39/.../libpython3.9.so), causing the parser to misinterpret the version numbers.
Changes:
Test plan: