Skip to content

Conversation

@ttgrules
Copy link
Contributor

Looks like "offset" was missed as a dynamic property of Spreadsheet_Excel_Writer_Worksheet.

It gets set in Workbook.php around lines 581 and 681, and will throw an error in PHP 8.3.

@sanmai sanmai self-requested a review October 14, 2025 12:45
@sanmai
Copy link
Member

sanmai commented Oct 14, 2025

Thanks for the PR! If you could find yourself writing a unit test hitting this line, I'd really, really appreciate that! But we'll ship it nevertheless.

@sanmai sanmai enabled auto-merge (squash) October 14, 2025 12:55
@sanmai sanmai merged commit a4bef3c into pear:master Oct 14, 2025
13 checks passed
@ttgrules ttgrules deleted the missing-dynamic-property branch October 14, 2025 13:27
@ttgrules
Copy link
Contributor Author

@sanmai Good call on the unit test! It looks like existing test cases hit it (every time ->close() is called on a workbook), but phpunit is currently configured to ignore deprecation warnings and move on.

Might be a broader question of what you want to catch or ignore, but I put together a pull request to update the PHPUnit config to show Deprecation notices and convert them to exceptions.

#51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants