Improve and add some pbpack related tooling #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stasia Michalska <[email protected]>
…into a directory Signed-off-by: Stasia Michalska <[email protected]>
Signed-off-by: Stasia Michalska <[email protected]>
jwise
reviewed
Nov 5, 2025
|
|
||
| import struct | ||
| import uuid | ||
| from functools import reduce |
Member
Author
There was a problem hiding this comment.
It's not, if you look at the line 72 in the original file, this is a missing import, that seemingly worked in python 2 by default
jwise
approved these changes
Nov 5, 2025
jwise
left a comment
jwise
left a comment
There was a problem hiding this comment.
LGTM -- is the functools line noise? if so, please remove it, otherwise, feel free to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whatever came up while patching the existing apps