URL-decode the response from config webview#30
Open
mddub wants to merge 1 commit intopebble:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS and Android return an already-URL-decoded string in the
webviewclosedevent, butpebble-tooldoes not.To reproduce:
"capabilities": ["configurable"]topackage.jsonsrc/js/app.jswith these contents:pebble emu-app-config, tail the logs.Result on emulator (Pebble tool v4.3, SDK v3.13.1):
Result on iOS (Pebble app v3.13.1, Basalt running v3.13):
I noticed the same problem in pypkjs:
https://github.com/pebble/pypkjs/blob/4b337b6/pypkjs/runner/terminal.py#L36
...but I'm not entirely clear on how/whether that project is used by pebble-tool + libpebble2.