Skip to content

Linux fixes for Pytorch linking#2

Merged
pedronahum merged 15 commits intopedronahum:mainfrom
thinkpractice:linux_fixes
Dec 15, 2025
Merged

Linux fixes for Pytorch linking#2
pedronahum merged 15 commits intopedronahum:mainfrom
thinkpractice:linux_fixes

Conversation

@thinkpractice
Copy link
Contributor

This is my ongoing progress on fixing the Linux linker issues. I've changed the following:

  • Use _GLIBCXX_USE_CXX11_ABI=1 to build pytorch and the swift package
  • Changed all references to clang-18 to clang-17
  • Commented out some projects that still have linker errors
  • Added a basic c++ Pytorch example to investigate linker errors.

At some point the linker errors for the tests were resolved but now I'm getting them back. Will investigate tomorrow what has happened.

@thinkpractice
Copy link
Contributor Author

Added examples back, only MNISTExample works, the other two crash. Also added ATenCXXDoctest back to the build. Not sure what this is meant to do but at least it runs with status SUCCESS!.

@thinkpractice
Copy link
Contributor Author

@pedronahum by applying some git "dark magic" 🤣 I did a hard reset to your main branch. I've add a couple of convenience shell scripts to make local development without docker easier and I've added a .devcontainer for vscode that helps developing in the container. Debugging doesn't work completely yet, need to investigate.

@thinkpractice
Copy link
Contributor Author

thinkpractice commented Dec 15, 2025

@pedronahum just merged your upstream main branch and will tests if everything still works. Then I will push the changes here. If you prefer I can make another PR instead and we close this one.

Also tried building with rocm. This works, but only have been using cpu until now. Will investigate what we need for gpu support

UPDATE: just merged upstream/main and pushed the changes here

@pedronahum
Copy link
Owner

Amazing @thinkpractice!!

@pedronahum pedronahum merged commit 442b734 into pedronahum:main Dec 15, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants