Open
Conversation
Member
|
🆒 could you update the documentation showing how to use this? |
Author
|
@dewski I've updated the README. Let me know if it looks good to you. |
Author
|
@dewski ping. Any reason not to merge this in? |
Member
|
@barunio sorry for the delayed response. There seems to be a merge conflict and I can't merge it until that is resolved. The docs look good to me! Another small note after reviewing the code again is it would be helpful to change the event prefixes from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a way to use peek-performance_bar with standard Ajax requests that are not carried out via Pjax or Turbolinks, simply by supporting custom
peek:startandpeek:endevents.For example, you could do something like this to update the performance bar for all Ajax requests: