Skip to content

Fix rack-mini-profiler conflit#9

Open
z4ppy wants to merge 1 commit intopeek:masterfrom
z4ppy:master
Open

Fix rack-mini-profiler conflit#9
z4ppy wants to merge 1 commit intopeek:masterfrom
z4ppy:master

Conversation

@z4ppy
Copy link

@z4ppy z4ppy commented May 26, 2018

Hello,

Thx for you work !

I made this patch so that peek-ng works with other pg monitoring tools.

@knightq
Copy link

knightq commented Jun 19, 2019

This solve a stack level too deep error on boot on Rails 4.2.11 with bootsnap:

Called from ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in register' Exiting Traceback (most recent call last): 8484: from bin/rails:4:in

'
8483: from ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/activesupport-4.2.11.1/lib/active_support/dependencies.rb:274:in require' 8482: from ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/activesupport-4.2.11.1/lib/active_support/dependencies.rb:240:in load_dependency'
8481: from ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/activesupport-4.2.11.1/lib/active_support/dependencies.rb:274:in block in require' 8480: from ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in require'
8479: from ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:21:in require_with_bootsnap_lfi' 8478: from ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/loaded_features_index.rb:92:in register'
8477: from ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/bootsnap-1.4.4/lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:22:in block in require_with_bootsnap_lfi' ... 8472 levels... 4: from ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/rack-mini-profiler-1.0.2/lib/patches/db/pg.rb:110:in async_exec'
3: from ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/peek-pg-1.3.0/lib/peek/views/pg.rb:21:in async_exec' 2: from ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/peek-pg-1.3.0/lib/peek/views/pg.rb:19:in ensure in async_exec'
1: from ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/activesupport-4.2.11.1/lib/active_support/core_ext/time/calculations.rb:251:in minus_with_coercion' ~/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/activesupport-4.2.11.1/lib/active_support/core_ext/time/calculations.rb:237:in minus_with_duration': stack level too deep (SystemStackError)

Can someone please merge?

@dombarnes
Copy link

Any likelihood of this getting merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants