Fixes bug in relation area processing #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oduce more than one closed polygon, because the 'closed' variable was not getting reset once one was found, so every subsequent member was being processed as if it close immediately. added a test with sample data that produces the correct result.
…her peermaps ecosystem forks, as the original repos do not seem to be getting any activity
… the INT and FLOAT vlaue types are being considered. not sure what to do with STRING types, since we can't through them straight at the GPU, so perhaps we drop them, and consider a task to the caller to consider a mapping from STRING to INT or FLOAT
- [encode] major: changes the encoding and decoding schema to include additional values based on tags. if no additional tags are included, then only an additional 0 is written to the end of the buffer - minor: adds the georender schema here, local to the repo to track changes.
…hat is part of the base of georender and what is a tag beyond that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closedvariable once set to true is not reset to false for subsequent member processing, so all following members are considered to be self closing, leading to render bugs. the fix is to reset theclosedvariable along with the other variables that track progress through the multipolygon.