Object reference, Semantic link support #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhere06
requested review from
4manasa,
paulgagnon-pega,
tumms2021389 and
vishalshrm539
samhere06
force-pushed
the
mod/decouplers/US-705201
branch
from
c802c9a to
f8e4354
Compare
4manasa
reviewed
Oct 8, 2025
| } | ||
| } | ||
|
|
||
| onRecordChange = event => { |
Contributor
There was a problem hiding this comment.
can we move this onRecordChange method implementation to ObjectReference component and access from there similar to DataReference component?
tammy-a11y
requested changes
Oct 9, 2025
Contributor
There was a problem hiding this comment.
let's move this file to '_helpers' folder and rename this as object-utils ?
Contributor
There was a problem hiding this comment.
similar to above comment, let's move this file to '_helpers' folder and rename this as semantic-link-utils ?
samhere06
force-pushed
the
mod/decouplers/US-705201
branch
from
27e7233 to
d2cd6ed
Compare
tammy-a11y
approved these changes
Oct 9, 2025
tammy-a11y
previously approved these changes
Oct 9, 2025
4manasa
previously approved these changes
Oct 10, 2025
Contributor
4manasa
left a comment
4manasa
left a comment
There was a problem hiding this comment.
Changes Looks good to me.
4manasa
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object reference, Semantic link support