Skip to content

fix: Two column layout fix #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tumms2021389 merged 1 commit into from
Dec 8, 2025
Merged

fix: Two column layout fix #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...lar-sdk-components/src/lib/_components/designSystemExtension/banner/banner.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@
column-gap: calc(2 * 0.5rem);
row-gap: calc(2 * 0.5rem);
align-items: start;

& > *:nth-child(2) {
min-width: 0;
}
}

.background-image-style {
Expand Down
1 change: 0 additions & 1 deletion packages/angular-sdk-components/src/lib/_components/infra/view/view.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ export class ViewComponent implements OnInit, OnDestroy, OnChanges {
this.showLabel$ = this.configProps$.showLabel || isDetailsTemplate(this.templateName$) || this.showLabel$;
// label & showLabel within inheritedProps takes precedence over configProps
this.label$ = this.inheritedProps$.label || this.label$;
this.showLabel$ = this.inheritedProps$.showLabel || this.showLabel$;
// children may have a 'reference' so normalize the children array
this.arChildren$ = ReferenceComponent.normalizePConnArray(this.pConn$.getChildren());
this.visibility$ = this.configProps$.visibility ?? this.visibility$;
Expand Down
12 changes: 5 additions & 7 deletions ...ular-sdk-components/src/lib/_components/template/default-page/default-page.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,11 @@ <h1 *ngIf="title">{{ title }}</h1>
'psdk-grid-filter-narrow-wide': this.layout$ === 'narrow-wide'
}"
>
<div>
<component-mapper
*ngFor="let child of arChildren$"
[name]="child.getPConnect().getComponentName()"
[props]="{ pConn$: child.getPConnect() }"
></component-mapper>
</div>
<component-mapper
*ngFor="let child of arChildren$"
[name]="child.getPConnect().getComponentName()"
[props]="{ pConn$: child.getPConnect() }"
></component-mapper>
</div>
</div>
</ng-template>