Skip to content

fix: Label should not be displayed for listview template #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tumms2021389 merged 1 commit into from
Dec 17, 2025
Merged

fix: Label should not be displayed for listview template #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/angular-sdk-components/src/lib/_components/infra/view/view.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { getAllFields } from '../../template/utils';
import { ReferenceComponent } from '../reference/reference.component';
import { ComponentMapperComponent } from '../../../_bridge/component-mapper/component-mapper.component';

const NO_HEADER_TEMPLATES = ['SubTabs', 'SimpleTable', 'Confirmation', 'DynamicTabs', 'DetailsSubTabs'];
const NO_HEADER_TEMPLATES = ['SubTabs', 'SimpleTable', 'Confirmation', 'DynamicTabs', 'DetailsSubTabs', 'ListView'];
const DETAILS_TEMPLATES = [
'Details',
'DetailsFields',
Expand Down Expand Up @@ -158,10 +158,9 @@ export class ViewComponent implements OnInit, OnDestroy, OnChanges {

this.templateName$ = this.configProps$.template || '';
this.title$ = this.configProps$.title || '';
this.label$ = this.configProps$.label || '';
this.showLabel$ = this.configProps$.showLabel || isDetailsTemplate(this.templateName$) || this.showLabel$;
// label & showLabel within inheritedProps takes precedence over configProps
this.label$ = this.inheritedProps$.label || this.label$;
this.label$ = this.inheritedProps$.label || this.configProps$.label || '';
this.showLabel$ = this.inheritedProps$.showLabel || this.configProps$.showLabel || isDetailsTemplate(this.templateName$);
// children may have a 'reference' so normalize the children array
this.arChildren$ = ReferenceComponent.normalizePConnArray(this.pConn$.getChildren());
this.visibility$ = this.configProps$.visibility ?? this.visibility$;
Expand Down