Skip to content

Commit 3a56aa3

Browse files
ISSUE-138440: revert changes in ListViewComponent.kt and ListViewRenderer.kt
1 parent d3e99e7 commit 3a56aa3

File tree

2 files changed

+1
-24
lines changed
  • core/src/commonMain/kotlin/com/pega/constellation/sdk/kmp/core/components/containers
  • ui-renderer-cmp/src/commonMain/kotlin/com/pega/constellation/sdk/kmp/ui/renderer/cmp/containers

2 files changed

+1
-24
lines changed

core/src/commonMain/kotlin/com/pega/constellation/sdk/kmp/core/components/containers/ListViewComponent.kt

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,10 @@ import com.pega.constellation.sdk.kmp.core.Log
77
import com.pega.constellation.sdk.kmp.core.api.BaseComponent
88
import com.pega.constellation.sdk.kmp.core.api.ComponentContext
99
import com.pega.constellation.sdk.kmp.core.api.ComponentEvent
10-
import com.pega.constellation.sdk.kmp.core.components.ComponentTypes.ActionButtons
1110
import com.pega.constellation.sdk.kmp.core.components.containers.ListViewComponent.SelectionMode.MULTI
1211
import com.pega.constellation.sdk.kmp.core.components.containers.ListViewComponent.SelectionMode.SINGLE
1312
import com.pega.constellation.sdk.kmp.core.components.getJSONArray
1413
import com.pega.constellation.sdk.kmp.core.components.getString
15-
import com.pega.constellation.sdk.kmp.core.components.widgets.ActionButtonsComponent
1614
import kotlinx.serialization.json.JsonArray
1715
import kotlinx.serialization.json.JsonElement
1816
import kotlinx.serialization.json.JsonObject
@@ -36,7 +34,6 @@ class ListViewComponent(context: ComponentContext) : BaseComponent(context) {
3634
private set
3735
var items by mutableStateOf(emptyList<Item>())
3836
private set
39-
private var selectedItemIndexToSubmit: Int? = null
4037

4138
override fun applyProps(props: JsonObject) {
4239
label = props.getString("label")
@@ -51,29 +48,13 @@ class ListViewComponent(context: ComponentContext) : BaseComponent(context) {
5148
.map {
5249
Item(it.toFoldedItemContent(emptyMap(), ""))
5350
}
54-
checkAutoSubmit()
5551
}
5652

5753
fun onItemSelected(itemIndex: Int) {
5854
selectedItemIndex = itemIndex
5955
context.sendComponentEvent(itemSelectedEvent(itemIndex))
6056
}
6157

62-
fun setValueToAutoSubmit(selectedItemIndex: Int) {
63-
selectedItemIndexToSubmit = selectedItemIndex
64-
}
65-
66-
fun checkAutoSubmit() {
67-
if (selectedItemIndexToSubmit != null && selectedItemIndex == selectedItemIndexToSubmit) {
68-
selectedItemIndexToSubmit = null
69-
val actionButtons = context.componentManager.getComponents()
70-
.first { it.context.type == ActionButtons } as? ActionButtonsComponent
71-
actionButtons?.primaryButtons?.firstOrNull()?.let {
72-
actionButtons.onClick(it)
73-
}
74-
}
75-
}
76-
7758
private fun itemSelectedEvent(itemIndex: Int) =
7859
ComponentEvent(
7960
type = SELECT_SINGLE_ITEM_EVENT,

ui-renderer-cmp/src/commonMain/kotlin/com/pega/constellation/sdk/kmp/ui/renderer/cmp/containers/ListViewRenderer.kt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.pega.constellation.sdk.kmp.ui.renderer.cmp.containers
22

33
import androidx.compose.runtime.Composable
4-
import androidx.compose.runtime.LaunchedEffect
54
import com.pega.constellation.sdk.kmp.core.components.containers.ListViewComponent
65
import com.pega.constellation.sdk.kmp.core.components.containers.ListViewComponent.SelectionMode
76
import com.pega.constellation.sdk.kmp.ui.components.cmp.controls.form.Table
@@ -20,10 +19,7 @@ class ListViewRenderer : ComponentRenderer<ListViewComponent> {
2019
columnsLabels = columnLabels,
2120
items = items.map { TableItem(it.data) },
2221
selectedItem = selectedItem?.let { TableItem(it.data) },
23-
onItemClick = {
24-
setValueToAutoSubmit(it)
25-
onItemSelected(it)
26-
}
22+
onItemClick = ::onItemSelected
2723
)
2824
}
2925

0 commit comments

Comments
 (0)