Skip to content

Commit c8c0a46

Browse files
ISSUE-138440: minor changes in AndroidWebViewEngine.kt
1 parent 3a56aa3 commit c8c0a46

File tree

5 files changed

+9
-9
lines changed
  • engine-webview/src/androidMain/kotlin/com/pega/constellation/sdk/kmp/engine/webview/android
  • samples
    • android-cmp-app/src
      • androidInstrumentedTest/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test
      • androidMain/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp
    • android-compose-app/src/main/java/com/pega/constellation/sdk/kmp/samples/androidcomposeapp
  • test/src/androidDeviceTest/kotlin/com/pega/constellation/sdk/kmp/test

5 files changed

+9
-9
lines changed

engine-webview/src/androidMain/kotlin/com/pega/constellation/sdk/kmp/engine/webview/android/AndroidWebViewEngine.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ import java.util.concurrent.TimeUnit
4545

4646
class AndroidWebViewEngine(
4747
private val context: Context,
48+
private val lifecycleScope: CoroutineScope,
4849
private val okHttpClient: OkHttpClient,
49-
private val nonDxOkHttpClient: OkHttpClient = defaultHttpClient(),
50-
private val lifecycleScope: CoroutineScope
50+
private val nonDxOkHttpClient: OkHttpClient = defaultHttpClient()
5151
) : ConstellationSdkEngine {
5252

5353
private lateinit var config: ConstellationSdkConfig

samples/android-cmp-app/src/androidInstrumentedTest/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/test/ComposeTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ abstract class ComposeTest(
4242
private val context = instrumentation.targetContext
4343
private val authManager = AuthManager(scope, FakeAuthFlowFactory(), FakeTokenStore(mode.token))
4444
private val httpClient = buildHttpClient(authManager)
45-
private val engine = AndroidWebViewEngine(context, httpClient, httpClient, scope)
45+
private val engine = AndroidWebViewEngine(context, scope, httpClient, httpClient)
4646

4747
@BeforeTest
4848
fun setUp() {

samples/android-cmp-app/src/androidMain/kotlin/com/pega/constellation/sdk/kmp/samples/androidcmpapp/MediaCoActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ class MediaCoActivity : ComponentActivity() {
3030

3131
val engine = AndroidWebViewEngine(
3232
context = this,
33-
okHttpClient = buildHttpClient(authManager),
34-
lifecycleScope = this.lifecycleScope
33+
lifecycleScope = this.lifecycleScope,
34+
okHttpClient = buildHttpClient(authManager)
3535
)
3636
Injector.init(authManager, engine)
3737
AppContext.init(this)

samples/android-compose-app/src/main/java/com/pega/constellation/sdk/kmp/samples/androidcomposeapp/AndroidComposeActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ class AndroidComposeActivity : ComponentActivity() {
7878
val caseClassName = AndroidSDKConfig.PEGA_CASE_CLASS_NAME
7979
val engine = AndroidWebViewEngine(
8080
context = this,
81-
okHttpClient = buildHttpClient(),
82-
lifecycleScope = this.lifecycleScope
81+
lifecycleScope = this.lifecycleScope,
82+
okHttpClient = buildHttpClient()
8383
)
8484
sdk = ConstellationSdk.create(config, engine)
8585
sdk.createCase(caseClassName)

test/src/androidDeviceTest/kotlin/com/pega/constellation/sdk/kmp/test/ConstellationSdkTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ class ConstellationSdkTest : ConstellationSdkBaseTest() {
1919
fun setup() {
2020
engine = AndroidWebViewEngine(
2121
context = appContext,
22+
lifecycleScope = scope,
2223
okHttpClient = MockHttpClient(appContext, PegaVersion.v24_1_0),
23-
nonDxOkHttpClient = MockHttpClient(appContext, PegaVersion.v24_1_0),
24-
lifecycleScope = scope
24+
nonDxOkHttpClient = MockHttpClient(appContext, PegaVersion.v24_1_0)
2525
)
2626
}
2727
}

0 commit comments

Comments
 (0)