TASK-1884601 - code review improvements#129
Merged
tomaszmlocek-pega merged 2 commits intofeature/pelcm/TASK-1884601-checkbox-multifrom Apr 2, 2026
Merged
Conversation
- Extract complex conditions into descriptive variables (shouldPreloadOptions, shouldDisplayOnlySingle, etc.) - Refactor #setChildDatasource() with early exits to reduce nesting - Remove commented-out code blocks - Remove TODO comment (readonly handling tracked in US-743258) - Extract multi-mode and single-mode logic into separate methods in CheckBoxComponent - Add early exit in #initMultiMode() for better readability - Replace if/else with when expression in CheckboxRenderer for exhaustive enum handling These changes improve code readability and maintainability while preserving existing functionality.
…fy #initMultiMode
marekpelc-pega
approved these changes
Apr 2, 2026
tomaszmlocek-pega
merged commit 158a443
into
feature/pelcm/TASK-1884601-checkbox-multi
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes improve code readability and maintainability while preserving existing functionality.