Issue #116 : Dispatch network calls to io dispatcher.#130
Open
lukjj-public-pega wants to merge 1 commit intomasterfrom
Open
Issue #116 : Dispatch network calls to io dispatcher.#130lukjj-public-pega wants to merge 1 commit intomasterfrom
lukjj-public-pega wants to merge 1 commit intomasterfrom
Conversation
| mainScope().launch(Dispatchers.IO) { | ||
| try { | ||
| Log.i(TAG, "Starting WKURLScheme task. <${startURLSchemeTask.request.URL}>") | ||
| val (data, response) = send(startURLSchemeTask.request) |
Contributor
There was a problem hiding this comment.
Please consider wrapping only send invocation with Dispatchers.IO :
val (data, response) = withContext(Dispatchers.IO) {
send(startURLSchemeTask.request)
}
Contributor
There was a problem hiding this comment.
By doing this we would dispatch actual request handling to the IO thread pool - but rest of the work would be still done on the main thread - so we would not need NSLocks to synchronize tasks access.
lukjj-public-pega
force-pushed
the
issue/116
branch
from
6ff78f7 to
83b1460
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea behind this one is to move network related calls (like finding delegate, etc) to the IO dispatcher as requested in #116 . This is done as
launch(context:)call so this will be removed oncemainScopeis cancelled.