TASK-1816943: Added support for startingFields for WKWebView based en… #52
Conversation
…gine. Extended API to support openAssignment action.
tomaszmlocek-pega
force-pushed
the
feature/mloct/TASK-1816943
branch
from
ecce1a9 to
e32a89b
Compare
| } | ||
|
|
||
|
|
||
| object ConstellationSdkKActionSerializer : KSerializer<ConstellationSdkAction> { |
There was a problem hiding this comment.
Most probably this custom serializer is not needed as kotlin should handle serialization of sealed classes out of the box. You just need to add @Serialiable to sealed class and subclasses and use type as a class discriminator instead of actionType.
| import kotlinx.serialization.json.Json | ||
|
|
||
| @Serializable | ||
| data class EngineConfiguration( |
There was a problem hiding this comment.
This seems to be implementation-detail of specific engine. I'd move it to engine-webview > commonMain and make it internal, as it is not something to be used by SDK clients. Btw - commonMain sourceset was recently created here: https://github.com/pegasystems/constellation-mobile-sdk/pull/49/files#diff-2398e22a8cacbeea18a4b5885f734cb50ef9029a687327c36481db76d377e40a
|
|
||
| private const val TAG = "JsonHelper" | ||
|
|
||
| fun Any.toJsonElement(): JsonElement? = when (this) { |
There was a problem hiding this comment.
It should be internal
tomaszmlocek-pega
force-pushed
the
feature/mloct/TASK-1816943
branch
from
eee20c5 to
634eaa9
Compare
| val jsonElements = this.mapNotNull { | ||
| it?.toJsonElement() ?: run { | ||
| val type = it?.let { it::class } ?: "null" | ||
| Log.w(TAG, "Unsupported type $type, cannot convert to JsonElement.") |
There was a problem hiding this comment.
Won't it result in duplicated logs for the same type? It seems that the same log will be printed from else branch (as we're calling toJsonElement recursively). I think we could get rid of that run {} block.
There was a problem hiding this comment.
good point - will refactor it
| if (config.action.actionType === "CreateCase") { | ||
| await createCase(config.action.caseClassName, config.action.startingFields); | ||
| } else if (config.action.actionType === "OpenAssignment") { | ||
| await openAssignment(config.action.assignmentId); |
There was a problem hiding this comment.
I think that it is okay for now, but in the future we should consider making it possible to "interact" with the application/engine instead of just reinitializing everything each time we want to open or create something.
| }; | ||
|
|
||
| console.log("[OpenAssignment]", "Opening assignment: " + assignmentId); | ||
| await PCore.getMashupApi().openAssignment(assignmentId, PCore.getConstants().APP.APP, options); |
There was a problem hiding this comment.
Wow, that's so simple 😎
lukaszgajewski-pega
left a comment
lukaszgajewski-pega
left a comment
There was a problem hiding this comment.
Code review completed, please take a look at my comments.
…gine. Extended API to support openAssignment action.