ISSUE-138342: Support for CompositeKeys in ListView component #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #shouldReloadData(oldPayload, newPayload) { | ||
| // Fields to exclude from comparison (they contain selection values, not data config). | ||
| // What might be surpising - the `selectionKey` and `primaryField` props contain actual value, not the column name. | ||
| const excludedFields = ["value", "selectionKey", "contextPage", "primaryField"]; |
Contributor
There was a problem hiding this comment.
const excludedFields seems to be unused
|
|
||
| #shouldReloadData(oldPayload, newPayload) { | ||
| // Fields to exclude from comparison (they contain selection values, not data config). | ||
| // What might be surpising - the `selectionKey` and `primaryField` props contain actual value, not the column name. |
Contributor
There was a problem hiding this comment.
typo in word surpising
tomaszmlocek-pega
force-pushed
the
bugfix/mloct/ISSUE-138342
branch
from
0e48d1b to
5042ea9
Compare
marekpelc-pega
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.