-
Notifications
You must be signed in to change notification settings - Fork 34
CLI lets user choose between health check and decision analyzer #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…health_check and decision analyzer
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
==========================================
- Coverage 67.60% 67.12% -0.49%
==========================================
Files 66 66
Lines 6474 6528 +54
==========================================
+ Hits 4377 4382 +5
- Misses 2097 2146 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@jmelburg thanks :) I think we could perhaps solve this by adding the optional dependencies in app to the dependencies list? Something like this uv should pick it up. https://docs.astral.sh/uv/guides/scripts/ I wonder if we just need streamlit or other things too? |
|
uv picks it up, uvx does not there are some vaguely related issues (astral-sh/uv#6542) at uv raised already, but nothing indicating this will become possible. I see two options now:
If we really want option 3 |
|
I’m fine with #1
Op vr 21 nov 2025 om 16:03 schreef Jonas ***@***.***>
… *jmelburg* left a comment (pegasystems/pega-datascientist-tools#468)
<#468 (comment)>
uv picks it up, uvx does not
there are some vaguely related issues (astral-sh/uv#6542
<astral-sh/uv#6542>) at uv raised already, but
nothing indicating this will become possible. I see two options now:
1. use uv run pdstools and declare the app dependency group as
dependency in the cli.py script header
- Straightforward
- Does not work globally
2. use uvx 'pdstools[app]'
- Works globally
- Slightly annoying syntax
If we really want option 3 uvx pdstools I can raise another issue
—
Reply to this email directly, view it on GitHub
<#468 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEVTKCSDPORJAUKXXISIOD354SSVAVCNFSM6AAAAACMVOGWT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNRTGM4DQNZTHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Pretty sure we could make both of these work at the same time, right? Let's document these two in the documentation and call it a day :) |
|
Found a middle ground solution:
ensures @StijnKas could you review and publish if it's all okay? |
supersedes #395
resolves #465
the streamlit import error is due to it not being included in the core dependencies. You have to run this:
uvx 'pdstools[app]'If this is acceptable I think it now all works as expected, though I can't properly test it with uvx before we publish a new version.
For now I was testing with:
uv tool install -e '.[app]' uvx pdstoolsI'm not sure
uvx pdstoolscan work out of the box without making streamlit a core dependency.