Framework to support the same metric limits as in the Databricks layer #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 67.89% 68.99% +1.10%
==========================================
Files 66 68 +2
Lines 6671 6921 +250
==========================================
+ Hits 4529 4775 +246
- Misses 2142 2146 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Remove CDH_Guidelines class, move all limits to MetricLimits.csv - Add convenience methods: minimum(), maximum(), best_practice_min(), best_practice_max() - Methods raise KeyError for unknown metric IDs - Add evaluate_metric_rag() for Python-based RAG evaluation - Add tests verifying Python/Polars RAG equivalence - Update reports to use MetricLimits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlighting of values in the ADM health check is based on an export of the same metric limits that we use for the Databricks layer. Source of truth is an Excel sheet that is exported to CSV that is part of both systems. The PDS tools utilities support highlighting the values from a Polars dataframe rending it to either a great_tables or itables display format. The previous mechanism in CDHGuidelines is removed, making this technically a breaking change, but there are not many clients of this functionality.