Skip to content

Replace the existing Phone comp with mui-tel-input #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tumms2021389 merged 2 commits into from
Nov 12, 2024
Merged

Replace the existing Phone comp with mui-tel-input #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d59cdb
Replace the existing Phone comp with mui-tel-input
Nov 11, 2024
afe1106
Merge branch 'master' into mod/tor/US-650250
tumms2021389 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 31 additions & 29 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"downloadjs": "^1.4.7",
"fast-deep-equal": "^3.1.3",
"lodash.difference": "^4.5.0",
"material-ui-phone-number": "^3.0.0",
"mui-tel-input": "^6.0.1",
"react": "^17.0.2",
"react-datepicker": "^4.25.0",
"react-dom": "^17.0.2",
Expand Down
10 changes: 5 additions & 5 deletions packages/react-sdk-components/src/components/field/Phone/Phone.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useEffect, useState } from 'react';
import MuiPhoneNumber from 'material-ui-phone-number';
import { MuiTelInput } from 'mui-tel-input';

import { getComponentFromMap } from '../../../bridge/helpers/sdk_component_map';
import { PConnFieldProps } from '../../../types/PConnProps';
Expand Down Expand Up @@ -57,12 +57,12 @@ export default function Phone(props: PhoneProps) {
const disableDropdown = true;
return (
<div>
<MuiPhoneNumber
<MuiTelInput
fullWidth
helperText={helperTextToDisplay}
placeholder={placeholder ?? ''}
size='small'
defaultCountry='us'
defaultCountry='US'
required={required}
disabled={disabled}
onChange={onChange}
Expand Down Expand Up @@ -91,13 +91,13 @@ export default function Phone(props: PhoneProps) {
};

return (
<MuiPhoneNumber
<MuiTelInput
fullWidth
variant='outlined'
helperText={helperTextToDisplay}
placeholder={placeholder ?? ''}
size='small'
defaultCountry='us'
defaultCountry='US'
required={required}
disabled={disabled}
onChange={handleChange}
Expand Down
4 changes: 3 additions & 1 deletion packages/react-sdk-components/tests/e2e/Digv2/FormFields/Phone.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,16 @@ test.describe('E2E test', () => {
const validationMsg = 'Enter a valid phone number';
await editablePhoneInput.clear();
await countrySelector.click();
await page.locator('text=United States+1 >> nth=0').click();
await page.locator('text=United Kingdom+44 >> nth=0').click();
/** Entering an invalid Phone number */
await common.enterPhoneNumber(editablePhone, '61');
await editablePhoneInput.blur();
/** Expecting an error for Invalid phone number */

await expect(page.locator(`p:has-text("${validationMsg}")`)).toBeVisible();

/** Entering a valid Phone number */
await editablePhoneInput.click();
await editablePhoneInput.clear();
await countrySelector.click();
await page.locator('text=United States+1 >> nth=0').click();
Expand Down