Skip to content

fix: Fixed empty label and text in datareference semanticlink field #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tumms2021389 merged 2 commits into from
Nov 10, 2025
Merged

fix: Fixed empty label and text in datareference semanticlink field #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27a45f2
fix: Fixed empty label and text in datareference semanticlink field
tammy-a11y Nov 7, 2025
fb0a737
Merge branch 'master' into datareference_fix
tumms2021389 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-sdk-components/src/components/field/SemanticLink/SemanticLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export default function SemanticLink(props: SemanticLinkProps) {

return (
<Link component='button' {...linkComponentProps} {...restProps} onClick={openLinkClick} data-testid={testId}>
{text}
{text || '--'}
</Link>
);
}
2 changes: 1 addition & 1 deletion packages/react-sdk-components/src/components/infra/View/View.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default function View(props: PropsWithChildren<ViewProps>) {
const localeUtils = PCore.getLocaleUtils();

const isEmbeddedDataView = mode === 'editable'; // would be better to check the reference child for `context` attribute if possible
if (isEmbeddedDataView && showLabel === undefined) {
if ((isEmbeddedDataView && showLabel === undefined) || (template === 'DataReference' && inheritedProps.showLabel === undefined)) {
showLabel = true;
}

Expand Down