Updated and Fixed the playwright tests in react-SDK #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4manasa
requested review from
paulgagnon-pega,
samhere06,
tumms2021389 and
vishalshrm539
vrseraphin
reviewed
Nov 14, 2024
| ) | ||
| ]); | ||
| await expect(page.locator('CircularProgress')).not.toBeVisible(); | ||
| await page.waitForTimeout(5000); |
Contributor
There was a problem hiding this comment.
Don't understand why you would want to add timeouts...seems like that would make the tests flakey. We should discuss.
Contributor
Author
There was a problem hiding this comment.
These are the existing tests which we added in components repo.I don't see any failures with above code.
Contributor
There was a problem hiding this comment.
Waiting on Promise was making tests flaky in test VM, so we decided to stick with the elements visible on screen thats why added circular progress check. Just to be sure the element is reflected on ui we are waiting for 5 seconds.
vishalshrm539
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.