Skip to content

Fix flakey test #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vrseraphin wants to merge 1 commit into from
Closed

Fix flakey test #535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/e2e/MediaCo/portal.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,27 +106,27 @@ test.describe('E2E test', () => {
const filePath = path.join(__dirname, '../../../assets/img/cableinfo.jpg');

const attachmentID = await page.locator('div[id="attachment-ID"]').textContent();
await page.setInputFiles(`#${attachmentID}`, filePath);

const pCoreVersion = await page.evaluate(() => window.PCore.getPCoreVersion());
const isInfinity23OrHigher = ['8.23.0', '23.1.1'].includes(pCoreVersion);

// Need to be waiting for the transaction before code to trigger the transaction
await Promise.all([
page.waitForResponse(
`${endpoints.serverConfig.infinityRestServerUrl}${
endpoints.serverConfig.appAlias ? `/app/${endpoints.serverConfig.appAlias}` : ''
}/api/application/v2/attachments/upload`
)
),
page.setInputFiles(`#${attachmentID}`, filePath)
]);

await page.locator('button:has-text("submit")').click();

await Promise.all([
page.waitForResponse(
`${endpoints.serverConfig.infinityRestServerUrl}${
endpoints.serverConfig.appAlias ? `/app/${endpoints.serverConfig.appAlias}` : ''
}/api/application/v2/cases/${currentCaseID}/attachments${isInfinity23OrHigher ? '?includeThumbnail=false' : ''}`
)
),
page.locator('button:has-text("submit")').click()
]);

const attachmentCount = await page.locator('div[id="attachments-count"]').textContent();
Expand Down