Moved storybook mocks to Preview #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vishalshrm539
commented
Jul 1, 2025
vishalshrm539
commented
- Moved storybook mocks to Preview.
vishalshrm539
requested review from
4manasa,
paulgagnon-pega,
samhere06 and
tumms2021389
tumms2021389
requested changes
Jul 1, 2025
.storybook/preview.tsx
Outdated
| }; | ||
|
|
||
| export default preview; | ||
| function pcoreMocks() { |
Collaborator
There was a problem hiding this comment.
add a line break before this function
.storybook/preview.tsx
Outdated
Comment on lines
11
to
21
| declare global { | ||
| interface Window { | ||
| PCore?: any; | ||
| } | ||
| } | ||
|
|
||
| declare global { | ||
| interface Window { | ||
| PCore?: any; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
looks like global declaration is duplicated
tumms2021389
previously approved these changes
Jul 1, 2025
tumms2021389
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.