Draft
Conversation
Pennsylvania, IN and Pennsylvania Township, IN are technically not the same place (the township includes the village/city/whatever it's called). However, we should deduplicate them, under our general rules of parents with similar names being deduped. If someone really wants the township they can type 'Pennsylvania Township'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an extension to #556 that uses GIDs and other brittle methods to expand deduplication test cases.
In the short term, it means we can do a better job of specifying exactly how we want results to appear when testing deduplication.
However, in the long term, it would likely mean occasional work to update GIDs or other test details to keep the tests up to date. For that reason we might not want to merge them.