-
Notifications
You must be signed in to change notification settings - Fork 54
Update panel-setup.mdx #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
need to run setup as root
📝 WalkthroughWalkthroughA documentation update modifying the command example in the panel setup guide by adding the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for pelica ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
according to @notAreYouScared on discord, this needs to be ran as root for the setup to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/panel/panel-setup.mdx
🔇 Additional comments (1)
docs/panel/panel-setup.mdx (1)
13-13: The documented approach for Pelican panel installation is correct. Usingsudo php artisan p:environment:setupis the recommended method, and the subsequentchowncommands (lines 33, 38, 43) properly transfer ownership to the web server user after the artisan setup command creates the.envfile with root ownership. This three-step workflow—setup with sudo, set permissions, then change ownership to the web server user—is consistently applied throughout the installation documentation and is the intended process.
need to run setup as root
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.